-
Notifications
You must be signed in to change notification settings - Fork 290
feat: support message delivered and message sent statuses separately #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size Change: +3.23 kB (+0.28%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
# Conflicts: # package.json # yarn.lock
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
- Coverage 81.59% 81.46% -0.14%
==========================================
Files 493 495 +2
Lines 9994 10010 +16
Branches 2272 2278 +6
==========================================
Hits 8155 8155
- Misses 1727 1741 +14
- Partials 112 114 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎉 This PR is included in version 13.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎯 Goal
Have the following message status distinctions in the message list:
sending
sent
delivered
read
Have the following message status distinctions in the channel preview:
sent
delivered
read
The
sending
status will be supported in theChannelPreview
once there is reactive state forChannel
instance.Closes REACT-502
🛠 Implementation details
deliveredTo
property toMessageContext
(along already existingreadBy
). It is an array ofUserResponse
objects representing users that have confirmed the delivery or have read the messagereadBy
anddeliveredTo
MessageContext
properties are now extracted fromchannel.ownMessageReceiptsTracker
which retrieves the relevant items using binary search instead of the previous iteration over all the read objects X all the messages.Depends on
🎨 UI Changes
Sent message status (single tick) - NEW:
Delivered message status (double tick) - CHANGED ACCORDING TO DESIGNS
Docs
https://github.com/GetStream/docs-content/pull/631